Implementation of methods login and findByEmail #914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ivan95kos
suggested changes
Jan 20, 2024
| @@ -11,6 +13,11 @@ public class AuthenticationService { | |||
| * Return false in any other cases. | |||
| */ | |||
| public boolean login(String email, String password) { | |||
| User user = new UserService().findByEmail(email); | |||
There was a problem hiding this comment.
UserService must be a class field
Suggested change
| User user = new UserService().findByEmail(email); | |
| User user = userService.findByEmail(email); |
kerrrusha
suggested changes
Jan 20, 2024
| public class AuthenticationService { | ||
| private UserService userService; |
There was a problem hiding this comment.
- field is not initialized
- make it
final
Comment on lines
20
to
23
| if (user != null) { | ||
| return user.getPassword().equals(password); | ||
| } | ||
| return false; |
There was a problem hiding this comment.
good code is simple code. think about how to make it inline
kerrrusha
suggested changes
Jan 20, 2024
Comment on lines
20
to
23
| if (user != null && user.getPassword().equals(password)) { | ||
| return true; | ||
| } | ||
| return false; |
kerrrusha
approved these changes
Jan 20, 2024
| return false; | ||
| User user = userService.findByEmail(email); | ||
|
|
||
| return (user != null && user.getPassword().equals(password)) ? true : false; |
There was a problem hiding this comment.
really not bad try, but... seriously?))
Suggested change
| return (user != null && user.getPassword().equals(password)) ? true : false; | |
| return user != null && user.getPassword().equals(password)); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.